Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve descriptor validation #5

Closed
karl-lunarg opened this issue May 14, 2018 · 2 comments
Closed

Improve descriptor validation #5

karl-lunarg opened this issue May 14, 2018 · 2 comments
Assignees
@tobine
Labels
Enhancement New feature or request
Milestone
sdk-1.1.97.0

Comments

@karl-lunarg
Copy link
Contributor

Issue by tobine (MIGRATED)
Wednesday Aug 24, 2016 at 13:12 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#880

This is a tracking issue for some improvements that can be made to how descriptors are validated.

  1. Pre-sort the std::map of descriptor bindings into an array after initial creation as the only subsequent use is to walk it in-order.
  2. Implement test to demonstrate that bindings are correctly parsed in-order to correlate with appropriate dyn_offset_index (this was previously broken and have start of test in branch tobin_gh867_dyn_offset_test)
  3. Add checks for physical limits such as maxUniformBufferRange
  4. Error (or warn) if dynamic offset plus BufferInfo offset exceeds BufferInfo range? Currently only error if all three of these values exceed the underlying buffer range.
@karl-lunarg karl-lunarg added this to the P2 milestone May 14, 2018
@karl-lunarg karl-lunarg added Enhancement New feature or request VUID labels May 14, 2018
@karl-lunarg
Copy link
Contributor Author

Comment by tobine (MIGRATED)
Thursday Feb 02, 2017 at 22:10 GMT

This covers VALIDATION_ERROR_00948, VALIDATION_ERROR_00949, VALIDATION_ERROR_00952. Going to work on those.

@tobine
Copy link
Contributor

tobine commented Dec 20, 2018

Checking these items and it appears they're all addressed in the code now.

@tobine tobine closed this as completed Dec 20, 2018
@shannon-lunarg shannon-lunarg modified the milestones: P2, sdk-1.1.97.0 Jul 24, 2019
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
9110796 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
f136431 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
f7e7386 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
6de8695 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
87261da 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
723293d 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
c70e06c 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.
mark-lunarg pushed a commit that referenced this issue Mar 3, 2020
@AttilioProvenzano-ARM @mark-lunarg
practices: Add a set of Arm-specific checks
b147616 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks #5-6, #9, #15, #22, #25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 5, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
3d59c56 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 10, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
05698c5 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 10, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
23def3e 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 10, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
fca5def 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 10, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
882bad8 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 10, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
0fd5737 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Mar 11, 2020
@AttilioProvenzano-ARM
practices: Add a set of Arm-specific checks
3c7c0fd 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks KhronosGroup#5-6, KhronosGroup#9, KhronosGroup#15, KhronosGroup#22, KhronosGroup#25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
mark-lunarg pushed a commit that referenced this issue Mar 11, 2020
@AttilioProvenzano-ARM @mark-lunarg
practices: Add a set of Arm-specific checks
02859b2 
This commit adds checks regarding:
 - Blending with multisampled images
 - Too large sample count
 - Non-lazily allocated MS images
 - Various potential issues with samplers
 - Using vkCmdResolveImage
 - Many small indexed draw calls
 - Using ONE_TIME_SUBMIT bit
 - Attachments that need tile readback

This corresponds to checks #5-6, #9, #15, #22, #25-31 from PerfDoc.

Change-Id: I19de83c1806dacace2b3acbb742a105afd24f627
This was referenced Jul 9, 2020
Merged
Merged
@mark-lunarg mark-lunarg mentioned this issue Aug 6, 2020
Merged
lunarpapillo added a commit that referenced this issue Apr 17, 2021
@lunarpapillo
docs: update #5
816d6b1
@nisse-work nisse-work mentioned this issue Jul 12, 2021
Closed
@rikusalminen rikusalminen mentioned this issue Apr 22, 2022
Closed
@jbauman42 jbauman42 mentioned this issue Oct 21, 2022
Closed
@jbauman42 jbauman42 mentioned this issue Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobine tobine

Labels
Enhancement New feature or request
Projects
None yet
Milestone
sdk-1.1.97.0
Development

No branches or pull requests
4 participants
@tobine @karl-lunarg @KarenGhavam-lunarG @shannon-lunarg