vulkaninfo: On X11 use default visual #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the visual passed to XCreateWindow is not the default one, it can cause a BadMatch error. Usually the first one returned does work, but in certain cases we need to search through all the visuals to find one that matches the default visual. This was seen on an xrdp session on Rocky 9.
|
Author rp42 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author rp42 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
approved these changes
Oct 23, 2024
|
CI Vulkan-Tools build queued with queue ID 285339. |
|
CI Vulkan-Tools build # 1552 running. |
|
CI Vulkan-Tools build # 1552 passed. |
|
Thank you again for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the visual passed to XCreateWindow is not the default one, it can cause a BadMatch error. Usually the first one returned does work, but in certain cases we need to search through all the visuals to find one that matches the default visual. This was seen on an xrdp session on Rocky 9.
Fixes #1042