Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary access to the old swapchain in hello triangle sample #1227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unnecessary access to the old swapchain in hello triangle sample #1227

wants to merge 1 commit into from

Conversation

SaschaWillems
Copy link
Collaborator

Description

This PR removes an unnecessary access to the retired swapchain just get a number to iterate over a vector. Instead of doing that, the code now simply iterates over that vector.

Replaces #1019

Fixes #1015

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@SaschaWillems
Remove unnecessary access to the old swapchain just for getting image…
f2122dc 
… count

The image count is only used to teardown per-frame resources
That's already a vector, so we can simply iterate over that
@SaschaWillems SaschaWillems changed the title Remove unnecessary access to the old swapchain Remove unnecessary access to the old swapchain in hello triangle sample Nov 15, 2024
@SaschaWillems SaschaWillems mentioned this pull request Nov 24, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-sweet gary-sweet gary-sweet approved these changes

@asuessenbach asuessenbach asuessenbach approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hello_triangle sample references a retired swapchain
3 participants
@SaschaWillems @asuessenbach @gary-sweet