apple: Fix incorrect version linker warning #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 64185. |
|
CI Vulkan-Loader build # 2252 running. |
juan-lunarg
commented
Oct 16, 2023
.github/workflows/build.yml
Outdated
| @@ -350,6 +350,7 @@ jobs: | |||
| # Specify the minimum version of macOS on which the target binaries are to be deployed. | |||
| # https://cmake.org/cmake/help/latest/envvar/MACOSX_DEPLOYMENT_TARGET.html | |||
| MACOSX_DEPLOYMENT_TARGET: 10.12 | |||
| LDFLAGS: -fatal_warnings | |||
There was a problem hiding this comment.
We should enable linker warnings as errors for our MacOS SDK builds. FYI @richard-lunarg
There was a problem hiding this comment.
To be more specific all of our SDK testing should treat warnings as errors. Not just Mac.
Comment on lines
+391
to
+392
| # Workaround linker warning: https://github.com/KhronosGroup/Vulkan-Loader/issues/1332 | ||
| set(APPLE_VULKAN_LOADER_VERSION "${VULKAN_LOADER_VERSION_MAJOR}.${VULKAN_LOADER_VERSION_MINOR}.0") |
There was a problem hiding this comment.
This sets it to 1.3.0 instead of 1.3.268
|
CI Vulkan-Loader build # 2252 passed. |
Sets the patch version to 0 to avoid the linker warning Enable warnings as errors on CI to prevent regression closes #1332
|
CI Vulkan-Loader build queued with queue ID 64199. |
1 similar comment
|
CI Vulkan-Loader build queued with queue ID 64199. |
|
CI Vulkan-Loader build # 2253 running. |
|
CI Vulkan-Loader build # 2253 passed. |
|
Note this will also affect the installed files. Example |
|
CI passed on fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the patch version to 0 to avoid the linker warning
Enable warnings as errors on CI to prevent regression
closes #1332