-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CodeQL as SAST Tool #1303
Conversation
Author joycebrum not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author joycebrum not on autobuild list. Waiting for curator authorization before starting CI build. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change I'd like to ask is to squash the commits down into one. Otherwise it looks very nice. I see the list of issues the code analyzer found, and will create PR for them shortly.
Signed-off-by: Joyce Brum <[email protected]>
Author joycebrum not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author joycebrum not on autobuild list. Waiting for curator authorization before starting CI build. |
Just wanted to say thanks for doing the legwork of implementing this! Very nice to have and already has found some questionable code! |
Closes #1300
I've configured it to run on c files and python.
For C, I've configured manually the build using as example the build.yml workflow. Let me know if I missed anything. There were only 10 findings on the codeql run.
As you said, I focused on the C build and just kept the python part because the autobuild was working well for it. Let me know if it would be better to drop it.