Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong exported blendshape normals and tangents when using sparse accessors #712

Merged

Conversation

pfcDorn
Copy link
Contributor

@pfcDorn pfcDorn commented Mar 12, 2024

Wrong accessor export method was used for exporting blendshape tangents with sparse, and fixed wrong deltaVertices was used instead of deltaNormals.

image
image

Test Models:
[MorphWithNormalAndTangents.zip]https://github.com/KhronosGroup/UnityGLTF/files/14569743/MorphWithNormalAndTangents.zip)

cubeToSphere.zip

@pfcDorn pfcDorn force-pushed the fix/blendshape-sparse-export branch from a75d322 to f877df9 Compare March 12, 2024 08:54
@pfcDorn pfcDorn changed the title Fixed wrong exported blendshape tangents when using sparse accessors Fixed wrong exported blendshape normals and tangents when using sparse accessors Mar 12, 2024
@pfcDorn pfcDorn force-pushed the fix/blendshape-sparse-export branch from f877df9 to bc4cd8f Compare March 12, 2024 09:12
@hybridherbst hybridherbst merged commit e369759 into KhronosGroup:dev Apr 4, 2024
1 check passed
@hybridherbst hybridherbst deleted the fix/blendshape-sparse-export branch April 14, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants