Change return type for "abs_diff" #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `abs_diff` so that its return type is the same as the type of its parameters. This makes the signature consistent with `abs`. Closes internal issue 655.
nliber
approved these changes
Aug 25, 2023
gmlueck
changed the base branch from
gmlueck/gentype-funcs-v2
to
SYCL-2020/master
|
Ready to merge. |
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Nov 16, 2023
As of KhronosGroup/SYCL-Docs#458 the return type of abs_diff has been changed to be the same as the input arguments, which in turn corresponds to how the extended OpenCL instruction set defines `s_abs_diff`. This commit changes the preview builtins to use the correct type as well as define `s_abs_diff` in accordance with the OpenCL extended instruction set. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
to steffenlarsen/SYCL-CTS
that referenced
this pull request
Nov 16, 2023
Following KhronosGroup/SYCL-Docs#458 the return type of abs_diff was changed to be the same as the input types. This commit makes the corresponding changes to the CTS tests for it. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Nov 16, 2023
As of KhronosGroup/SYCL-Docs#458 the return type of abs_diff has been changed to be the same as the input arguments, which in turn corresponds to how the extended OpenCL instruction set defines s_abs_diff. This commit changes the preview builtins to use the correct type similar to how `sycl::abs` does. Signed-off-by: Larsen, Steffen <[email protected]>
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 21, 2023
As of KhronosGroup/SYCL-Docs#458 the return type of abs_diff has been changed to be the same as the input arguments, which in turn corresponds to how the extended OpenCL instruction set defines s_abs_diff. This commit changes the preview builtins to use the correct type similar to how `sycl::abs` does. --------- Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
to KhronosGroup/SYCL-CTS
that referenced
this pull request
Nov 23, 2023
Following KhronosGroup/SYCL-Docs#458 the return type of abs_diff was changed to be the same as the input types. This commit makes the corresponding changes to the CTS tests for it. Signed-off-by: Larsen, Steffen <[email protected]>
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Change return type for "abs_diff"
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Change return type for "abs_diff" (cherry picked from commit 385ecd5)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Change return type for "abs_diff" (cherry picked from commit 385ecd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
abs_diffso that its return type is the same as the type of its parameters. This makes the signature consistent withabs.Closes internal issue 655.