Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SPV_EXT_optnone #2951

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Jan 6, 2025

Specifically:

  • Updates SPIR-V headers to the latest tag, to pull in support for SPV_EXT_optnone (and more).
  • Removes all internal enums for SPV_INTEL_optnone and uses the support in the headers instead.
  • Registers the SPV_EXT_optnone extension.
  • Uses the SPV_EXT_optnone extension if it is enabled, otherwise uses the SPV_INTEL_optnone extension if it is enabled, otherwise ignores the OptimizeNone attribute (the ignoring part is not new).
  • Updates the OptNone test:
    • Ensures that the right extension support is declared, depending on the enabled extensions.
    • Ensures that the OptNone capability is declared when either extension is enabled. Note, the spelling for the capability is unconditionally the EXT version.
    • Ensures that the Function Control is present when either extension is enabled.

@svenvh svenvh requested review from MrSidims and vmaksimo January 7, 2025 08:52
@MrSidims MrSidims merged commit dd33e59 into KhronosGroup:main Jan 7, 2025
9 checks passed
@bashbaug bashbaug deleted the SPV_EXT_optnone branch January 8, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants