[SPIR-V 1.2] SPIRVReader: Support LocalSizeHintId #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode.
vmaksimo
approved these changes
Dec 4, 2024
MrSidims
approved these changes
Dec 5, 2024
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 11, 2024
…hronosGroup#2907) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2923) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2922) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2921) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2920) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2919) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
svenvh
added a commit
that referenced
this pull request
Dec 16, 2024
…2907) (#2918) If there is no `OpExecutionMode .. LocalSizeHint` in the input, see if there is an `OpExecutionModeId .. LocalSizeHintId` and take the value for the `work_group_size_hint` metadata from the referenced constants instead. Once `LocalSizeHintId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `LocalSizeHint` execution mode. (cherry picked from commit 420f5dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
OpExecutionMode .. LocalSizeHintin the input, see if there is anOpExecutionModeId .. LocalSizeHintIdand take the value for thework_group_size_hintmetadata from the referenced constants instead.Once
LocalSizeHintIdhas been translated to LLVM IR, it is indistinguishable from a (non-ID)LocalSizeHintexecution mode.