Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DebugInfo] Fix EnumClass support #2876

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[DebugInfo] Fix EnumClass support #2876

merged 1 commit into from
Dec 6, 2024

Conversation

bwlodarcz
Copy link
Contributor

This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.

MrSidims
MrSidims reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are LGTM, can we have a LIT for this?

@bwlodarcz
Copy link
Contributor Author

bwlodarcz commented Dec 3, 2024 •
edited
Loading

@MrSidims We have such test in test/DebugInfo/X86/enum-class.ll.

@MrSidims MrSidims merged commit 50af2c7 into KhronosGroup:main Dec 6, 2024
9 checks passed
matborzyszkowski pushed a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@bwlodarcz @matborzyszkowski
[Backport to 19][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
0715368 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 19][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
29e518e 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 18][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
ba6ce63 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 17][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
49788de 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 17][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
8271270 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 16][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
bfc45bf 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 15][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
8086fa0 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
matborzyszkowski added a commit to matborzyszkowski/SPIRV-LLVM-Translator that referenced this pull request Dec 17, 2024
@matborzyszkowski
[Backport to 14][DebugInfo] Fix EnumClass support (KhronosGroup#2876)
d748d6b 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 19][DebugInfo] Fix EnumClass support (#2876) (#2937)
b14e489 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 18][DebugInfo] Fix EnumClass support (#2876) (#2938)
cd8fd41 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 17][DebugInfo] Fix EnumClass support (#2876) (#2939)
9e0d675 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 16][DebugInfo] Fix EnumClass support (#2876) (#2940)
0fec1b8 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 15][DebugInfo] Fix EnumClass support (#2876) (#2941)
dacd7d0 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
vmaksimo pushed a commit that referenced this pull request Dec 20, 2024
@matborzyszkowski
[Backport to 14][DebugInfo] Fix EnumClass support (#2876) (#2942)
9558e59 
This commit addresses issues with EnumClass handling in DebugEnumType.
In reverse translation, a bug caused the EnumClass flag to be incorrectly applied to every DebugEnumType with an UnderlyingType.
Additionally, in forward translation, the support for EnumClassFlag was missing entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSidims MrSidims MrSidims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwlodarcz @MrSidims