Remove unecessary include that require c++20 #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone help to merge this? Thank you! |
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 16, 2024
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 16, 2024
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 16, 2024
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 16, 2024
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 16, 2024
MrSidims
pushed a commit
that referenced
this pull request
Jul 17, 2024
MrSidims
pushed a commit
that referenced
this pull request
Jul 17, 2024
MrSidims
pushed a commit
that referenced
this pull request
Jul 17, 2024
MrSidims
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ating memory size (#2649) * [DebugInfo] Round up #elts of TypeVector when calculating memory size (#2504) Round up number of elements in a Vector to a power of 2 when calculating memory size. Memory size will be calculated as BaseType * bit_ceil(ComponentCount). The previous calculation already rounded 3 elements to 4 elements. Signed-off-by: Lu, John <[email protected]> * Avoid requiring C++20 (#2600) bit_ceil requires C++20. Use llvm::bit_ceil to avoid this requirement. Signed-off-by: Lu, John <[email protected]> * Remove unecessary include that require c++20 (#2628) * Add own bit_ceil implementation. Signed-off-by: Marcos Maronas <[email protected]> Signed-off-by: Lu, John <[email protected]>
MrSidims
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ating memory size (#2648) * [DebugInfo] Round up #elts of TypeVector when calculating memory size (#2504) Round up number of elements in a Vector to a power of 2 when calculating memory size. Memory size will be calculated as BaseType * bit_ceil(ComponentCount). The previous calculation already rounded 3 elements to 4 elements. Signed-off-by: Lu, John <[email protected]> * Avoid requiring C++20 (#2600) bit_ceil requires C++20. Use llvm::bit_ceil to avoid this requirement. Signed-off-by: Lu, John <[email protected]> * Remove unecessary include that require c++20 (#2628) * Add own bit_ceil implementation. Signed-off-by: Marcos Maronas <[email protected]> Signed-off-by: Lu, John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aab92ecc22e2f1e fix the usage ibut did not remove the include.