-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for the 'fcmp false' instruction #2251
add support for the 'fcmp false' instruction #2251
Conversation
@MrSidims @bwlodarcz Can you please have a look |
Unfortunately the 'fcmp' instruction can go through vector also. I prepared test:
llvm-as and translator passes but spirv-val
Without further investigation I interpret this error that ConstantFalse is constant type declaration. In SPIRV |
@bwlodarcz Thank you. Let's represent a vector of false values as a OpConstantNull ("The null value is type dependent, defined as follows: - Scalar Boolean: false ... Composites: Members are set recursively to the null constant according to the null value of their constituent types.") |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There is no direct equivalent for "fcmp false" in the specification [https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_relational_and_logical_instructions], but we may return ConstantFalse in this case instead of reporting error.
This patch depends on #2216