[Backport to 8] Support SPV_EXT_relaxed_printf_string_address_space extension #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra variables, simplified code, removed dead code related to "read_image" handling: it is not present in OpenCL.std extended instruction set and therefore we can't encounter it in `transOCLBuiltinFromExtInst` function.
Added possibility to emit SPIR-V friendly IR instead of OpenCL-C-like mangled function names for instructions from OpenCL extended instruction set.
…vloada_halfn OpenCL EIS instructions
…CL pass This change also fixes vstore translation for SPV-IR generation path and adds test for vstore and printf.
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport is a squash of #1364, #1749, #1818
Also 4 changes for SPIR-V friendly IR were backported to allow SPIR-V friendly mangling.
Without these patches the extension can't be used, because llvm-spirv can't generate
printffunction for different address spaces arguments in reverse translation.