adds SPIR-V tests for scalar printf operands #2211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
reviewed
Jan 10, 2025
| // TODO: Unify with test_printf. | ||
| struct StreamGrabber | ||
| { | ||
| StreamGrabber(): tempFileName(get_temp_filename()) {} |
There was a problem hiding this comment.
This leaks: get_temp_filename() returns a char * that needs to be free()d, but here after initialization that pointer is lost so the memory itself never gets freed.
| const char* spirvFileName, | ||
| const char* kernelName, | ||
| const char* expectedResults, T value) | ||
| { |
There was a problem hiding this comment.
The new tests currently fail on our implementation because the output isn't captured (the OpenCL spec leaves the "output stream" implementation defined). The printf suite already has some extra handling to set up a call-back if the cl_arm_printf extension is supported (see #434); any chance you could add such handling to this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds targeted SPIR-V tests for printf with scalar operands. See:
The fp32 test is likely to be the most interesting, especially on devices that support fp64, because printf with scalar fp32 operands is not generated by default in this case with Clang and the SPIR-V LLVM Translator.