Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing for SPIR-V 1.5 #2208

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bashbaug
Copy link
Contributor

fixes #2140

Adds testing for SPIR-V 1.5 features:

  • Adds a test for bitcasts between pointers and vectors of integers. Note, SPIR-V 1.5 only supports bitcasts to vectors of two 32-bit integers. Therefore, the SPIR-V 1.5 behavior will only be exercised on devices with 64-bit pointers. The test will run on devices with 32-bit pointers, but will instead bitcast to scalars.
  • Adds a test for OpGroupNonUniformBroadcast with a dynamic index. Note, this is not an exhaustive test, and only unsigned integer types are tested, to avoid duplicating testing for cl_khr_subgroup_ballot.

@bashbaug
Copy link
Contributor Author

Note: Implementations using the SPIR-V LLVM Translator will likely need this fix to pass the bitcast test: KhronosGroup/SPIRV-LLVM-Translator#2948

@svenvh svenvh self-requested a review January 3, 2025 09:30
Copy link
Member

@svenvh svenvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few nitpicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPIR-V 1.5 Testing
2 participants