Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to enable running on tvOS 13 #2330

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fixes to enable running on tvOS 13 #2330

merged 1 commit into from
Sep 10, 2024

Conversation

warmenhoven
Copy link
Contributor

Two parts:

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cdavis5e
cdavis5e requested changes Sep 9, 2024
View reviewed changes
MoltenVK/MoltenVK.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
MoltenVK/MoltenVK.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
MoltenVK/MoltenVK/Commands/MVKCommandResourceFactory.mm Outdated Show resolved Hide resolved
billhollings
billhollings reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

A couple of questions about the linking workaround.

MoltenVK/MoltenVK.xcodeproj/project.pbxproj Show resolved Hide resolved
billhollings
billhollings approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@billhollings billhollings merged commit 8a94475 into KhronosGroup:main Sep 10, 2024
6 checks passed
@warmenhoven warmenhoven deleted the warmenhoven/pr/tvos13 branch September 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhollings billhollings billhollings approved these changes

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@warmenhoven @CLAassistant @billhollings @cdavis5e