Support Vulkan requirement to allow write or copy beyond descriptor binding size. #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inding size. - Revert to allowing vkUpdateDescriptorSets() to write or copy beyond the end of a descriptor binding count if subsequent descriptors are of the same type. This fixes a regression caused by 7fe7423, that added a guard against writing or copying past a descriptor binding size. - Add MVKInlineUniformBlockDescriptor::writeBytes() & readBytes() to support updating byte contents, and allow vkUpdateDescriptorSets() to break a write or copy of a large byte range into multiple inline uniform block descriptors of smaller size.
cdavis5e
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to allowing
vkUpdateDescriptorSets()to write or copy beyond the end of a descriptor binding count if subsequent descriptors are of the same type. This fixes a regression caused by 7fe7423 in PR Add additional defensive code within vkUpdateDescriptorSets(). #2293, that added a guard against writing or copying past a descriptor binding size.Add
MVKInlineUniformBlockDescriptor::writeBytes()&readBytes()to support updating byte contents, and allowvkUpdateDescriptorSets()to break a write or copy of a large byte range into multiple inline uniform block descriptors of smaller size.