Emit primitiveRestartEnable disabled warning only for strip topology. #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move check and warning to MVKRenderingCommandEncoderState. - Pass primitiveRestartEnable to MVKRenderingCommandEncoderState. - Warn only if primitiveRestartEnable disabled and strip topology is used.
|
What about triangle fans? |
Good catch! I had tried working that in, but because there is no Metal triangle fan topology value, I ended up having to double-track both Metal and Vulkan topology values in Triangle fan restart will work (it's handled in the index conversion), but like strips in Metal, cannot be disabled. The app log just won't see a warning for TriStrips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKRenderingCommandEncoderState.primitiveRestartEnabletoMVKRenderingCommandEncoderState.primitiveRestartEnabledisabled and strip topology is used.Fixes issue #2045.