Update conda build workflow #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
folmos-at-orange
commented
Dec 12, 2023
•
folmos-at-orange
commented
- Pin mpich version
- Pin conda build version
- Eliminate osx-64 docker
- Add conda build readme
folmos-at-orange
added
Type/Bug
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
b2bc73d to
6cf0368
Compare
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
2 times, most recently
from
d2ab52f to
26abc55
Compare
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
26abc55 to
ba89e98
Compare
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
2 times, most recently
from
78154b9 to
b1f530f
Compare
popescu-v
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Technically, almost LGTM (see the three comments).
However, I think it would be best to run the full Khiops test suite, including the tests for the MPI-related bug KhiopsML/khiops#104, on all supported platforms (Mac x86, Mac ARM, Linux x86), before approving this PR.
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
2 times, most recently
from
3628704 to
3514d82
Compare
popescu-v
force-pushed
the
full-conda-pkg-tests
branch
from
3514d82 to
11a3298
Compare
folmos-at-orange
removed
Type/Bug
The tests are Ok for the pinned versions. We can merge this. |
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
12 times, most recently
from
547d1fd to
06d1ad2
Compare
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
6 times, most recently
from
753be4a to
979761c
Compare
We pin the version of conda-build to not have problems with bugs in recent versions.
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
2 times, most recently
from
1dde790 to
8ba5d5e
Compare
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
8ba5d5e to
6d2efcb
Compare
popescu-v
reviewed
Feb 7, 2024
popescu-v
reviewed
Feb 7, 2024
popescu-v
reviewed
Feb 7, 2024
popescu-v
reviewed
Feb 7, 2024
popescu-v
reviewed
Feb 7, 2024
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
6d2efcb to
1491731
Compare
popescu-v
reviewed
Feb 7, 2024
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
1491731 to
2004434
Compare
We eliminate code obtaining the osx-arm64 conda packages to simplify the package workflow. In the meantime we will build and upload the packages for osx-arm64 manually. When we have access to osx-arm64 runners we'll stop to package it manually.
folmos-at-orange
force-pushed
the
full-conda-pkg-tests
branch
from
2004434 to
2022eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.