-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fei5402.1.node20workflows] Change workflows to node 20 #990
Conversation
🦋 Changeset detectedLatest commit: a3b0629 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 4.67 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 1393 1390 -3
Branches 359 343 -16
=========================================
- Hits 1393 1390 -3 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we're getting the node-gyp error here, as well, so I think this will require a more-systemic fix.
There's a different issue for Linux than macOS. It'll need a different approach |
Ah this is a Python 3.12 issue where the distutils module is deprecated. This won't affect devs right now since we're using 3.11. I'll work on a "fix" for workflows. Short term would be to use 3.11. |
Summary:
This updates our Wonder Blocks workflows to use Node 20.
In order to verify things, I learned some additional steps for macOS.
nvm use 20
)yarn
oryarn install
node-gyp
. You either need to install XCode command line tools (You can do this by runningxcode-select --install
and following the prompts), or switch to use those tools from your version of XCode (XCode 14.3.1 appears to cause a lot of errors) - you can do this by runningsudo xcode-select -s /Library/Developer/CommandLineTools
.yarn
oryarn install
after this and all should be well.Issue: FEI-5402
Test plan:
See above steps to get things installed properly for macOS.
I then ran:
yarn test
yarn lint
yarn typecheck
yarn build