Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Revert "Version Packages (#695)" #705

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

kevinbarabash
Copy link
Contributor

🖍 This is an audit! 🖍

Summary:

The publish failed because a script was trying to run 'npm test' for eslint-khan-plugin, but that script doesn't exist anymore now that we can run the eslint tests with the main jest config. I'll fix this in a followup PR. For now, this is a clean revert.

Issue: None

Test plan:

  • let CI run

@kevinbarabash kevinbarabash self-assigned this May 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: 879a76a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@khanacademy/eslint-plugin Major
@khanacademy/wonder-stuff-core Minor
@khanacademy/eslint-config Major
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-server Patch
@khanacademy/wonder-stuff-testing Patch
@khanacademy/wonder-stuff-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team May 15, 2023 15:59
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/dull-penguins-impress.md, .changeset/eight-days-teach.md, .changeset/eighty-lobsters-flash.md, .changeset/good-months-change.md, .changeset/grumpy-hats-dress.md, .changeset/shiny-bikes-happen.md, .changeset/sweet-apes-decide.md, packages/eslint-config-khan/CHANGELOG.md, packages/eslint-config-khan/package.json, packages/eslint-plugin-khan/CHANGELOG.md, packages/eslint-plugin-khan/package.json, packages/wonder-stuff-ci/CHANGELOG.md, packages/wonder-stuff-ci/package.json, packages/wonder-stuff-core/CHANGELOG.md, packages/wonder-stuff-core/package.json, packages/wonder-stuff-render-environment-jsdom/CHANGELOG.md, packages/wonder-stuff-render-environment-jsdom/package.json, packages/wonder-stuff-render-server/CHANGELOG.md, packages/wonder-stuff-render-server/package.json, packages/wonder-stuff-sentry/CHANGELOG.md, packages/wonder-stuff-sentry/package.json, packages/wonder-stuff-server/CHANGELOG.md, packages/wonder-stuff-server/package.json, packages/wonder-stuff-testing/CHANGELOG.md, packages/wonder-stuff-testing/package.json

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@kevinbarabash kevinbarabash merged commit f3127aa into main May 15, 2023
@kevinbarabash kevinbarabash deleted the revert-695 branch May 15, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants