Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] [rg.audit.1] Add custom flow file for render-environment-jsdom to work around flowgen issue #616

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

somewhatabstract
Copy link
Member

🖍 This is an audit! 🖍

Summary:

  • Add the faster flowgen script from Wonder Blocks, and include the "custom overrides" support.
  • Fix some flow type issues for core and render-environment-jsdom.

Issue: FEI-4960

Test plan:

yarn clean && yarn build && yarn build:types && yarn build:flowtypes

Also check that the types will work for the usages I have to hand.

@somewhatabstract somewhatabstract self-assigned this Apr 3, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: bdbff43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-core Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-server Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@somewhatabstract somewhatabstract requested a review from a team April 3, 2023 19:05
@khan-actions-bot khan-actions-bot requested a review from a team April 3, 2023 19:05
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/eleven-trains-rush.md, build-scripts/gen-flow-types.ts, packages/wonder-stuff-core/src/types.js.flow, packages/wonder-stuff-render-environment-jsdom/src/types.js.flow

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from Wonder Blocks, but edited to:

  • Use the correct path for packages/wonder-stuff-*
  • Remove React-specific tweaks

@somewhatabstract somewhatabstract merged commit 0299cc9 into main Apr 3, 2023
@somewhatabstract somewhatabstract deleted the rg.audit.1 branch April 3, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants