Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei4960.4.examples] Migrate examples #611

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Conversation

somewhatabstract
Copy link
Member

@somewhatabstract somewhatabstract commented Mar 31, 2023

Summary:

This migrates the various test examples from Khan/render-gateway and adds the infrastructure to run them (i.e. babel-watch).

Issue: FEI-4960

Test plan:

yarn typecheck
yarn build
yarn build:types
yarn --cwd packages/wonder-stuff-render-environment-jsdom example jsdom-simple
yarn --cwd packages/wonder-stuff-render-server example simple
yarn --cwd packages/wonder-stuff-render-server example error
yarn --cwd packages/wonder-stuff-render-server example logging

@somewhatabstract somewhatabstract self-assigned this Mar 31, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

🦋 Changeset detected

Latest commit: 9cbbe4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@somewhatabstract somewhatabstract requested a review from a team March 31, 2023 21:02
@khan-actions-bot khan-actions-bot requested a review from a team March 31, 2023 21:02
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Mar 31, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .codecov.yml, package.json, yarn.lock, .changeset/flat-pumas-unite.md, config/jest/test.config.js, packages/wonder-stuff-core/tsconfig.json, packages/wonder-stuff-i18n/tsconfig.json, packages/wonder-stuff-render-environment-jsdom/package.json, packages/wonder-stuff-render-environment-jsdom/tsconfig.json, packages/wonder-stuff-render-server/package.json, packages/wonder-stuff-render-server/tsconfig.json, packages/wonder-stuff-render-environment-jsdom/examples/README.md, packages/wonder-stuff-render-server/examples/README.md, packages/wonder-stuff-render-environment-jsdom/examples/jsdom-simple/render.ts, packages/wonder-stuff-render-environment-jsdom/examples/jsdom-simple/run.ts, packages/wonder-stuff-render-server/examples/error/run.ts, packages/wonder-stuff-render-server/examples/logging/run.ts, packages/wonder-stuff-render-server/examples/simple/run.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

Size Change: 0 B

Total Size: 4.42 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.78 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 970 B

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #611 (9cbbe4e) into main (07488a4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #611   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         1322      1319    -3     
  Branches       331       316   -15     
=========================================
- Hits          1322      1319    -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07488a4...9cbbe4e. Read the comment docs.

Base automatically changed from fei4960.3.rollup to main March 31, 2023 22:16
@somewhatabstract
Copy link
Member Author

The parent pull-request (#608) has been merged into main, but this branch (fei4960.4.examples) now has conflicts with the new base branch. These conflicts must be resolved before checks can complete on this pull-request.

Comment on lines +7 to +9
},
"references": [
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Remnants from trying to fix a small nit. Seemed better to leave it for now as it makes adding references easier in the long term and its inert.

Comment on lines +7 to +9
},
"references": [
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Remnants from trying to fix a small nit. Seemed better to leave it for now as it makes adding references easier in the long term and its inert.

packages/wonder-stuff-render-server/examples/README.md Outdated Show resolved Hide resolved
packages/wonder-stuff-render-server/examples/README.md Outdated Show resolved Hide resolved
@somewhatabstract somewhatabstract merged commit 7a3ba71 into main Apr 3, 2023
@somewhatabstract somewhatabstract deleted the fei4960.4.examples branch April 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants