-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fei4960.4.examples] Migrate examples #611
Conversation
🦋 Changeset detectedLatest commit: 9cbbe4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 4.42 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 1322 1319 -3
Branches 331 316 -15
=========================================
- Hits 1322 1319 -3 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
4d3b87e
to
f05add4
Compare
The parent pull-request (#608) has been merged into |
…package tsconfig.json files
b6d809e
to
32da85a
Compare
}, | ||
"references": [ | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Remnants from trying to fix a small nit. Seemed better to leave it for now as it makes adding references easier in the long term and its inert.
}, | ||
"references": [ | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Remnants from trying to fix a small nit. Seemed better to leave it for now as it makes adding references easier in the long term and its inert.
Summary:
This migrates the various test examples from Khan/render-gateway and adds the infrastructure to run them (i.e.
babel-watch
).Issue: FEI-4960
Test plan:
yarn typecheck
yarn build
yarn build:types
yarn --cwd packages/wonder-stuff-render-environment-jsdom example jsdom-simple
yarn --cwd packages/wonder-stuff-render-server example simple
yarn --cwd packages/wonder-stuff-render-server example error
yarn --cwd packages/wonder-stuff-render-server example logging