Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI-4957.11: Reorganize eslint configs #535

Merged
merged 4 commits into from
Feb 16, 2023
Merged

FEI-4957.11: Reorganize eslint configs #535

merged 4 commits into from
Feb 16, 2023

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Feb 16, 2023

Summary:

When I initially updating the eslint config to support TypeScript, I added settings to .eslintrc.js that I should've added to eslint-config-khan/index.js. Without these settings, using @khanacademy/eslint-config in other codebases would fail.

TODO:

  • update eslint-config-khan's package.json to have the appropriate peer deps

Issue: FEI-4957

Test plan:

  • add some lint
  • see that it's reported in VSCode
  • yarn lint, see that it's reported
  • fix the lint
  • yarn lint, see there's no lint

@kevinbarabash kevinbarabash self-assigned this Feb 16, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2023

🦋 Changeset detected

Latest commit: 5b9a7b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team February 16, 2023 15:53
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Feb 16, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .eslintrc.js, .changeset/long-hairs-turn.md, packages/eslint-config-khan/README.md, packages/eslint-config-khan/index.js, packages/eslint-config-khan/package.json

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

packages/eslint-config-khan/index.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@5c50724). Click here to learn what that means.
The diff coverage is 7.69%.

❗ Current head 0072bdc differs from pull request most recent head 5b9a7b7. Consider uploading reports for the commit 5b9a7b7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage        ?   94.57%           
=======================================
  Files           ?       62           
  Lines           ?      885           
  Branches        ?      224           
=======================================
  Hits            ?      837           
  Misses          ?       48           
  Partials        ?        0           
Impacted Files Coverage Δ
...nder-stuff-core/src/__tests__/entries.typestest.ts 0.00% <0.00%> (ø)
.../wonder-stuff-core/src/__tests__/keys.typestest.ts 0.00% <0.00%> (ø)
...onder-stuff-core/src/__tests__/values.typestest.ts 0.00% <0.00%> (ø)
packages/wonder-stuff-core/src/entries.ts 100.00% <100.00%> (ø)
packages/wonder-stuff-core/src/keys.ts 100.00% <100.00%> (ø)
packages/wonder-stuff-core/src/values.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c50724...5b9a7b7. Read the comment docs.

@kevinbarabash kevinbarabash requested review from jeresig and a team February 16, 2023 16:06
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

Size Change: 0 B

Total Size: 4.32 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/es/index.browser.js 1.68 kB
packages/wonder-stuff-sentry/dist/es/index.browser.js 1.66 kB
packages/wonder-stuff-testing/dist/es/index.browser.js 976 B

compressed-size-action

Base automatically changed from fei-4957.10 to main February 16, 2023 18:23
@kevinbarabash kevinbarabash merged commit 501b381 into main Feb 16, 2023
@kevinbarabash kevinbarabash deleted the fei-4957.11 branch February 16, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants