-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEI-4957.11: Reorganize eslint configs #535
Conversation
🦋 Changeset detectedLatest commit: 5b9a7b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage ? 94.57%
=======================================
Files ? 62
Lines ? 885
Branches ? 224
=======================================
Hits ? 837
Misses ? 48
Partials ? 0
Continue to review full report at Codecov.
|
Size Change: 0 B Total Size: 4.32 kB ℹ️ View Unchanged
|
7d741bf
to
d536f3e
Compare
156d491
to
9aec48d
Compare
d536f3e
to
3ce791e
Compare
9aec48d
to
8035e03
Compare
3ce791e
to
c581fde
Compare
8035e03
to
8c9afec
Compare
c581fde
to
8ed2605
Compare
8c9afec
to
6b36b14
Compare
8ed2605
to
7b6bfb9
Compare
6b36b14
to
08834c1
Compare
7b6bfb9
to
5d455e9
Compare
08834c1
to
7d5b5fc
Compare
5d455e9
to
98f9fe6
Compare
7d5b5fc
to
5a0d694
Compare
98f9fe6
to
2f456ec
Compare
5a0d694
to
cb71246
Compare
2f456ec
to
ae9fd05
Compare
cb71246
to
0072bdc
Compare
…t' to eslint-config-khan's README.md
…onfig-khan's package.json
0072bdc
to
5b9a7b7
Compare
Summary:
When I initially updating the eslint config to support TypeScript, I added settings to .eslintrc.js that I should've added to eslint-config-khan/index.js. Without these settings, using @khanacademy/eslint-config in other codebases would fail.
TODO:
Issue: FEI-4957
Test plan: