Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct flow types for isolateModules #431

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Correct flow types for isolateModules #431

merged 2 commits into from
Oct 13, 2022

Conversation

somewhatabstract
Copy link
Member

Summary:

Issue: XXX-XXXX

Test plan:

yarn flow
yarn test

@somewhatabstract somewhatabstract self-assigned this Oct 13, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 901dafa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@khanacademy/wonder-stuff-core Patch
@khanacademy/wonder-stuff-i18n Patch
@khanacademy/wonder-stuff-testing Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-server-google Patch
@khanacademy/wonder-stuff-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/weak-dolls-reflect.md, packages/wonder-stuff-core/src/kind-error.js, packages/wonder-stuff-core/src/__tests__/errors-from-error.test.js, packages/wonder-stuff-i18n/src/plugins/i18n-plugin.js, packages/wonder-stuff-i18n/src/utils/extract-i18n.js, packages/wonder-stuff-testing/src/jest/isolate-modules.js, packages/wonder-stuff-i18n/src/plugins/__tests__/i18n-plugin.test.js, packages/wonder-stuff-i18n/src/utils/__tests__/localize-file.test.js

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 13, 2022 21:24
@github-actions
Copy link
Contributor

Size Change: +2 B (0%)

Total Size: 3.94 kB

Filename Size Change
packages/wonder-stuff-testing/dist/es/index.browser.js 828 B +2 B (0%)
ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/es/index.browser.js 1.59 kB
packages/wonder-stuff-sentry/dist/es/index.browser.js 1.52 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #431 (901dafa) into main (29f1a1a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines          839       838    -1     
  Branches       230       223    -7     
=========================================
- Hits           839       838    -1     
Impacted Files Coverage Δ
packages/wonder-stuff-core/src/kind-error.js 100.00% <ø> (ø)
...kages/wonder-stuff-i18n/src/plugins/i18n-plugin.js 100.00% <100.00%> (ø)
...ckages/wonder-stuff-i18n/src/utils/extract-i18n.js 100.00% <100.00%> (ø)
...s/wonder-stuff-testing/src/jest/isolate-modules.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f1a1a...901dafa. Read the comment docs.

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for tweak the type of isolateModules. 🎉

Comment on lines +142 to +145
type Asset = {|
source: () => string,
size: () => number,
|};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: thanks for making this a separate type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd how changing the isolateModules typing caused these other errors to show up, but it was worth fixing them :)

@somewhatabstract somewhatabstract merged commit ddd526c into main Oct 13, 2022
@somewhatabstract somewhatabstract deleted the typesfix branch October 13, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants