-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct flow types for isolateModules #431
Conversation
🦋 Changeset detectedLatest commit: 901dafa The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +2 B (0%) Total Size: 3.94 kB
ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 839 838 -1
Branches 230 223 -7
=========================================
- Hits 839 838 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for tweak the type of isolateModules
. 🎉
type Asset = {| | ||
source: () => string, | ||
size: () => number, | ||
|}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: thanks for making this a separate type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd how changing the isolateModules typing caused these other errors to show up, but it was worth fixing them :)
Summary:
Issue: XXX-XXXX
Test plan:
yarn flow
yarn test