-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[objasinterface] Make sure that keys/values/entries are typed to work against class instances too #329
Conversation
… against class instances too Noticed in webapp that some uses are passing a class instance and we should support that. Flow error indicated using an interface rather than object type so that it would match both objects and class instances. So this does that.
🦋 Changeset detectedLatest commit: 0e14da4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 3.65 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for tweaking the Flow types to support class instances. 💚
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 833 833
Branches 229 222 -7
=========================================
Hits 833 833
Continue to review full report at Codecov.
|
Summary:
Noticed in webapp that some uses are passing a class instance and we should support that. Flow error indicated using an interface rather than object type so that it would match both objects and class instances. So this does that.
Issue: XXX-XXXX
Test plan:
yarn flow