QoL: Turn on automatic commit of changesets #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5929fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Dec 13, 2024
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: 0 B Total Size: 4.63 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 97 97
Lines 1392 1392
Branches 351 358 +7
=======================================
Hits 1390 1390
Misses 1 1
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
jeresig
approved these changes
Dec 16, 2024
jeremywiebe
added a commit
to Khan/wonder-blocks
that referenced
this pull request
Dec 16, 2024
## Summary: The `changesets` tooling supports a configuration option that causes `yarn changeset` to automatically add and commit the created file ([docs](https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#commit-boolean-or-module-path-as-a-string-or-a-tuple-like-modulepath-string-options-any)). NOTE: If there are existing changes in your local repo, these changes _will not_ be included in the commit (so it's safe to run `yarn changeset` no matter the state of your repo). There are PRs in other Khan Academy repos that use the Changesets tooling. We'll only land this if there's consensus across these other repos too: * Khan/wonder-stuff#1097 * #2394 (this PR) * Khan/perseus#2008 Issue: "none" ## Test plan: `yarn changeset` Fill in the details Once complete, run `git log` and you will see that the changeset entry you created has been added and committed to git - all that's left is to create the PR! Author: jeremywiebe Reviewers: jandrade, somewhatabstract Required Reviewers: Approved By: jandrade Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ gerald, ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⌛ undefined Pull Request URL: #2394
jeremywiebe
added a commit
to Khan/perseus
that referenced
this pull request
Dec 16, 2024
## Summary: The `changesets` tooling supports a configuration option that causes `yarn changeset` to automatically add and commit the created file ([docs](https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#commit-boolean-or-module-path-as-a-string-or-a-tuple-like-modulepath-string-options-any)). NOTE: If there are existing changes in your local repo, these changes _will not_ be included in the commit (so it's safe to run `yarn changeset` no matter the state of your repo). There are PRs in other Khan Academy repos that use the Changesets tooling. We'll only land this if there's consensus across these other repos too: * Khan/wonder-stuff#1097 * Khan/wonder-blocks#2394 * #2008 (this PR) Issue: "none" ## Test plan: `yarn changeset` Fill in the details Once complete, run `git log` and you will see that the changeset entry you created has been added and committed to git - all that's left is to create the PR! Author: jeremywiebe Reviewers: handeyeco, catandthemachines Required Reviewers: Approved By: handeyeco, catandthemachines Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x) Pull Request URL: #2008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
changesetstooling supports a configuration option that causesyarn changesetto automatically add and commit the created file (docs).NOTE: If there are existing changes in your local repo, these changes will not be included in the commit (so it's safe to run
yarn changesetno matter the state of your repo).There are PRs in other Khan Academy repos that use the Changesets tooling. We'll only land this if there's consensus across these other repos too:
Issue: "none"
Test plan:
yarn changesetFill in the details
Once complete, run
git logand you will see that the changeset entry you created has been added and committed to git - all that's left is to create the PR!