Fix eslint-plugin-khan tests so that they can be run using jest

[kevinb-khan]

Summary:

#1085 caused an issue where tests were only running for one of the eslint plugin rules. Thanks @beaesguerra for noticing this. This PR updates our testing setup so that we can use jest to run the eslint-plugin-khan tests instead of mocha. It also fixes a few failures that are due to changes in eslint and RuleTester's behaviour.

Issue: None

Test plan:

• yarn test

[changeset-bot]

🦋 Changeset detected

Latest commit: dc73c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[khan-actions-bot]

Gerald

Required Reviewers

• @Khan/frontend-infra for changes to yarn.lock, .changeset/rotten-spiders-hear.md, .github/workflows/node-ci.yml, config/jest/test-setup.js, config/jest/test.config.js, packages/eslint-plugin-khan/package.json, packages/eslint-plugin-khan/test/rules/array-type-style.test.ts, packages/eslint-plugin-khan/test/rules/jest-async-use-real-timers.test.ts, packages/eslint-plugin-khan/test/rules/jest-await-async-matchers.test.ts, packages/eslint-plugin-khan/test/rules/jest-enzyme-matchers.test.js, packages/eslint-plugin-khan/test/rules/no-one-tuple.test.ts, packages/eslint-plugin-khan/test/rules/react-no-method-jsx-attribute.test.ts, packages/eslint-plugin-khan/test/rules/react-no-subscriptions-before-mount.test.ts, packages/eslint-plugin-khan/test/rules/react-svg-path-precision.test.ts, packages/eslint-plugin-khan/test/rules/sync-tag.test.ts, packages/eslint-plugin-khan/test/rules/ts-no-error-suppressions.test.ts

---

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

[jeresig]

Ahh nice - thanks for the fixes!

[kevinb-khan]

Ahh nice - thanks for the fixes!

I love that we're able to use RuleTester with jest now. I'll make the same change to services/static/dev/eslint-plugin-static-service at some point so that we can run those tests using GitHub Actions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (86caa2d) to head (dc73c80).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1090   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          97       97           
  Lines        1392     1392           
  Branches      351      351           
=======================================
  Hits         1390     1390           
  Misses          1        1           
  Partials        1        1           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86caa2d...dc73c80. Read the comment docs.

[github-actions]

Size Change: 0 B

Total Size: 4.63 kB

ℹ️ View Unchanged

Filename	Size
packages/wonder-stuff-core/dist/browser/es/index.js	1.85 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js	1.65 kB
packages/wonder-stuff-testing/dist/browser/es/index.js	1.12 kB

_{compressed-size-action}

[kevinb-khan]

This was a duplicated test case which jest doesn't like.

[beaesguerra]

Thanks for the fix @kevinb-khan ! 🎉