-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fei5484.1.node20actions] Update actions to Node 20 variants #1021
Conversation
🦋 Changeset detectedLatest commit: 208d5ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 4.66 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 97 97
Lines 1392 1392
Branches 359 358 -1
=======================================
Hits 1390 1390
Misses 1 1
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
@jeremywiebe Were you able to solve the Node 16 error for the compressed-size-action in Perseus? |
Regarding this. The repo updated to Node 16 a year ago, but never published a new version. So technically, it's specifying node 12 and GitHub is forcing it to run with Node 16. I would envisage this action is abandoned and we want to plan accordingly (we use it in Perseus, Wonder Stuff, and Wonder Blocks). |
@jeresig @somewhatabstract I don't remember seeing an error with the I wonder if we should think about forking this action and just maintaining it ourselves in https://github.com/khan/actions ? Or look at different solutions like: |
Summary:
This updates our actions to use the Node 20 variants. This should mean almost no more Node 16 deprecation warnings, however, the
preactjs/compressed-size-action
has no Node 20 variant yet.Issue: FEI-5484
Test plan:
Put the PR up and see that the workflows run without any Node 16 deprecation warnings - except for those about
preactjs/compressed-size-action
.