Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei5402.2.removeheapdump] Remove heapdump support #1013

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

somewhatabstract
Copy link
Member

Summary:

This removes the heapdump peer dependency and support for heap dumps. We haven't used this in quite a while and it tends to cause Node upgrade issues. If we should need it to debug something in the future, we can always add it back.

Issue: FEI-5402

Test plan:

yarn install
yarn test
yarn typecheck

I did these steps under Node 20 and Node 16.

@somewhatabstract somewhatabstract self-assigned this Feb 12, 2024
@somewhatabstract somewhatabstract requested a review from a team February 12, 2024 21:20
Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 9bf9103

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@khanacademy/wonder-stuff-render-server Major
@khanacademy/wonder-stuff-server Major
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team February 12, 2024 21:20
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Feb 12, 2024

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to package.json, yarn.lock, .changeset/rare-zoos-move.md, packages/wonder-stuff-render-server/src/run-server.ts, packages/wonder-stuff-server/src/start-server.ts, packages/wonder-stuff-server/src/types.ts, packages/wonder-stuff-render-server/src/__tests__/run-server.test.ts, packages/wonder-stuff-server/src/__tests__/start-server.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Merging #1013 (9bf9103) into main (b3c527b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              main    #1013      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           97       97              
  Lines         1393     1390       -3     
  Branches       359      343      -16     
===========================================
- Hits          1393     1389       -4     
- Misses           0        1       +1     
Files Coverage Δ
...kages/wonder-stuff-render-server/src/run-server.ts 100.00% <ø> (ø)
packages/wonder-stuff-server/src/start-server.ts 98.03% <ø> (-1.97%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c527b...9bf9103. Read the comment docs.

Copy link
Contributor

Size Change: 0 B

Total Size: 4.67 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.13 kB

compressed-size-action

@somewhatabstract somewhatabstract merged commit 4fc7dbb into main Feb 12, 2024
7 of 8 checks passed
@somewhatabstract somewhatabstract deleted the fei5402.2.removeheapdump branch February 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants