-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fei5402.2.removeheapdump] Remove heapdump support #1013
Conversation
🦋 Changeset detectedLatest commit: 9bf9103 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 97 97
Lines 1393 1390 -3
Branches 359 343 -16
===========================================
- Hits 1393 1389 -4
- Misses 0 1 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Size Change: 0 B Total Size: 4.67 kB ℹ️ View Unchanged
|
Summary:
This removes the
heapdump
peer dependency and support for heap dumps. We haven't used this in quite a while and it tends to cause Node upgrade issues. If we should need it to debug something in the future, we can always add it back.Issue: FEI-5402
Test plan:
yarn install
yarn test
yarn typecheck
I did these steps under Node 20 and Node 16.