Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary: The tests didn't catch this because they were mocking it. The reason why we need to bother with these util wrappers around functions is that RuleTester doesn't provide a way to mock things so I ended up having to mock things in a hacky way. I added an assert() call to the place where we do the mocking, but I think we need rethink how we write eslint tests. We should probably create our own jest-based test harness, but that'll take some doing so I'm going to punt on it for now. Issue: None ## Test plan: - yarn --cwd packages/eslint-plugin-khan test Author: kevinbarabash Reviewers: jeresig, kevinbarabash Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ⏭ dependabot, ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Analyze (javascript) Pull Request URL: #647
- Loading branch information