Skip to content

Commit

Permalink
Fix wonder-stuff-i18n's dist/bin/ folder (#559)
Browse files Browse the repository at this point in the history
## Summary:
One of our cloud platform jobs is failing because dist/bin/gen-potfiles.ts was written instead of dist/bin/gen-profiles.js when wonder-stuff-i18n was built and published.  This PR fixes the issue by updating the build script to write bin files using hte .js extension instead of .ts.

Issue: None

## Test plan:
- ./packages/wonder-stuff-i18n/dist/bin/gen-potfile.js "../webapp/services/static/javascript/*.{js,jsx}" > JavaScript.pot
- cat JavaScript.pot
- see a bunch of strings ready for translations

Author: kevinbarabash

Reviewers: mahtabsabet, jeresig, somewhatabstract, nathanjd

Required Reviewers:

Approved By: mahtabsabet, jeresig, somewhatabstract

Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ⏭  dependabot

Pull Request URL: #559
  • Loading branch information
kevinbarabash authored Mar 6, 2023
1 parent a49f6ea commit 522b091
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/wise-trains-deny.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"ws-dev-build-settings": patch
"@khanacademy/wonder-stuff-i18n": patch
---

Fix build script to output bin files using .js as their extension
2 changes: 1 addition & 1 deletion build-settings/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const getPackageInfo = (commandLineArgs, pkgName) => {
name: pkgName,
format: "cjs",
platform: "node",
file: `dist/bin/${binFile}`,
file: `dist/bin/${binFile.replace(/\.ts$/, ".js")}`,
inputFile: `./src/bin/${binFile}`,
plugins: [preserveShebangs(), rollupExecutable()],
});
Expand Down

0 comments on commit 522b091

Please sign in to comment.