-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioGroup: Add flexible width to legend element to fill available space #2405
Conversation
…nding it to fill the available space
🦋 Changeset detectedLatest commit: 9465590 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (a432d96) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2405" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2405 |
Size Change: +4 B (0%) Total Size: 96.3 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-wbgjwitpcm.chromatic.com/ Chromatic results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the quick fix!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
============================
============================
Continue to review full report in Codecov by Sentry.
|
Summary:
Adds
width: 100%
tolegend
element to allow expanding it to fill theavailable space.
Note that this applies to both
RadioGroup
andCheckboxGroup
.Issue: XXX-XXXX
Test plan:
Navigate to
/?path=/docs/packages-form-radiogroup--docs#custom%20label
.Verify that the legend element is now full-bleed.