LabeledField + form field integration by beaesguerra · Pull Request #2395 · Khan/wonder-blocks

Commits on Dec 11, 2024

since all fields support error prop now, update it in the LabeledField error story
beaesguerra
committed
Let required be a string so it can be passed into the field
beaesguerra
committed
wire up error message logic with fields
beaesguerra
committed
set up validation story
beaesguerra
committed
Clear error message regardless on change if instantValidation is false so that external error messages set using the error prop can still be cleared. this is useful for clearing any backend errors.…
beaesguerra
committed
pass down error prop
beaesguerra
committed
include submit button in example
beaesguerra
committed
rename error prop to errorMessage so it is consistent. error refers to a boolean like the other form components
beaesguerra
committed
Add more details in LabeledField stories
beaesguerra
committed
TextField stories: use LabeledField and cleanup
beaesguerra
committed
TextArea stories: use LabeledField and cleanup
beaesguerra
committed
remove additional spacing under field if error message is not shown
beaesguerra
committed
Move focus to first field with an error in labeled field example
beaesguerra
committed
Add general form docs
beaesguerra
committed
Add LabeledTextField deprecation docs
beaesguerra
committed
Update story to handle empty fields when a form is submitted and fields are marked as required
beaesguerra
committed
combine a11y and form best practices docs
beaesguerra
committed
fill in validation props for selects and search field
beaesguerra
committed
make target area of label smaller so that empty space doesn't trigger the field focus
beaesguerra
committed
Update MultiSelect stories to use LabeledField
beaesguerra
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LabeledField + form field integration#2395

Commits on Dec 11, 2024

since all fields support error prop now, update it in the LabeledField error story

Let required be a string so it can be passed into the field

wire up error message logic with fields

set up validation story

Clear error message regardless on change if instantValidation is false so that external error messages set using the error prop can still be cleared. this is useful for clearing any backend errors.…

pass down error prop

include submit button in example

rename error prop to errorMessage so it is consistent. error refers to a boolean like the other form components

Add more details in LabeledField stories

TextField stories: use LabeledField and cleanup

TextArea stories: use LabeledField and cleanup

remove additional spacing under field if error message is not shown

Move focus to first field with an error in labeled field example

Add general form docs

Add LabeledTextField deprecation docs

Update story to handle empty fields when a form is submitted and fields are marked as required

combine a11y and form best practices docs

fill in validation props for selects and search field

make target area of label smaller so that empty space doesn't trigger the field focus

Update MultiSelect stories to use LabeledField

Commits on Dec 13, 2024

improve required field stories

Revert "make target area of label smaller so that empty space doesn't trigger the field focus"

Commits on Dec 14, 2024

use field's props for required and error props too so they don't get ignored. also use field's light prop to determine LabeledField's light prop

clean up stories and use LabeledField in variant stories

include aria-required in TextField and TextArea if it is required