-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wb1812.3.migratewb] Migrate Wonder Blocks off old id providers #2391
Conversation
🦋 Changeset detectedLatest commit: b7a8236 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (e25e77c) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2391" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2391 |
Size Change: 0 B Total Size: 97 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-sgbfhzshor.chromatic.com/ Chromatic results:
|
a4c7d10
to
86f7984
Compare
2ef7ec6
to
3fb3e27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! thanks for the quick refactor
86f7984
to
62179a2
Compare
3fb3e27
to
568e232
Compare
62179a2
to
e3f9403
Compare
f691ba9
to
0097e62
Compare
e3f9403
to
e8b1a5e
Compare
a9734a4
to
b7a8236
Compare
Summary:
This is the last piece in the first batch of work. This migrates all Wonder Blocks components off our old ID providers and onto the new
Id
component.There are also some documentation tweaks to make the deprecation clearer in our stories, since that's some primary documentation for folks.
With this PR, we can cut a release and then begin updating consumer repos accordingly. First, to include this update, then to migrate them off the old ways and onto the new.
Release process:
Once this small stack of PRs are landed and released, the following PRs need to be updated with that release, then landed/deployed:
Issue: WB-1812
Test plan:
yarn test
yarn typecheck
yarn start:storybook