Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wb1812.3.migratewb] Migrate Wonder Blocks off old id providers #2391

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

somewhatabstract
Copy link
Member

@somewhatabstract somewhatabstract commented Dec 11, 2024

Summary:

This is the last piece in the first batch of work. This migrates all Wonder Blocks components off our old ID providers and onto the new Id component.

There are also some documentation tweaks to make the deprecation clearer in our stories, since that's some primary documentation for folks.

With this PR, we can cut a release and then begin updating consumer repos accordingly. First, to include this update, then to migrate them off the old ways and onto the new.

Release process:

Once this small stack of PRs are landed and released, the following PRs need to be updated with that release, then landed/deployed:

Issue: WB-1812

Test plan:

yarn test
yarn typecheck
yarn start:storybook

@somewhatabstract somewhatabstract self-assigned this Dec 11, 2024
@somewhatabstract somewhatabstract requested a review from a team December 11, 2024 22:36
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: b7a8236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@khanacademy/wonder-blocks-search-field Major
@khanacademy/wonder-blocks-accordion Major
@khanacademy/wonder-blocks-dropdown Major
@khanacademy/wonder-blocks-popover Major
@khanacademy/wonder-blocks-testing Major
@khanacademy/wonder-blocks-tooltip Major
@khanacademy/wonder-blocks-switch Major
@khanacademy/wonder-blocks-modal Major
@khanacademy/wonder-blocks-form Major
@khanacademy/wonder-blocks-core Patch
@khanacademy/wonder-blocks-birthday-picker Patch
@khanacademy/wonder-blocks-banner Patch
@khanacademy/wonder-blocks-breadcrumbs Patch
@khanacademy/wonder-blocks-button Patch
@khanacademy/wonder-blocks-cell Patch
@khanacademy/wonder-blocks-clickable Patch
@khanacademy/wonder-blocks-data Patch
@khanacademy/wonder-blocks-grid Patch
@khanacademy/wonder-blocks-icon-button Patch
@khanacademy/wonder-blocks-icon Patch
@khanacademy/wonder-blocks-labeled-field Patch
@khanacademy/wonder-blocks-layout Patch
@khanacademy/wonder-blocks-link Patch
@khanacademy/wonder-blocks-pill Patch
@khanacademy/wonder-blocks-progress-spinner Patch
@khanacademy/wonder-blocks-toolbar Patch
@khanacademy/wonder-blocks-typography Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Dec 11, 2024

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/witty-panthers-shave.md, __docs__/wonder-blocks-core/id.mdx, __docs__/wonder-blocks-core/use-unique-id.mdx, __docs__/wonder-blocks-timing/with-action-scheduler.stories.tsx, packages/wonder-blocks-accordion/src/components/accordion-section.tsx, packages/wonder-blocks-core/src/components/id-provider.tsx, packages/wonder-blocks-core/src/components/id.tsx, packages/wonder-blocks-core/src/components/unique-id-provider.tsx, packages/wonder-blocks-dropdown/src/components/action-menu.tsx, packages/wonder-blocks-dropdown/src/components/combobox.tsx, packages/wonder-blocks-dropdown/src/components/listbox.tsx, packages/wonder-blocks-dropdown/src/components/multi-select.tsx, packages/wonder-blocks-dropdown/src/components/single-select.tsx, packages/wonder-blocks-form/src/components/choice-internal.tsx, packages/wonder-blocks-form/src/components/labeled-text-field.tsx, packages/wonder-blocks-form/src/components/text-area.tsx, packages/wonder-blocks-form/src/components/text-field.tsx, packages/wonder-blocks-modal/src/components/modal-header.tsx, packages/wonder-blocks-modal/src/components/one-pane-dialog.tsx, packages/wonder-blocks-popover/src/components/popover.tsx, packages/wonder-blocks-search-field/src/components/search-field.tsx, packages/wonder-blocks-switch/src/components/switch.tsx, packages/wonder-blocks-tooltip/src/components/tooltip-anchor.tsx, packages/wonder-blocks-tooltip/src/components/tooltip.tsx, packages/wonder-blocks-dropdown/src/components/__tests__/action-menu.test.tsx, packages/wonder-blocks-dropdown/src/components/__tests__/multi-select.test.tsx, packages/wonder-blocks-dropdown/src/components/__tests__/single-select.test.tsx, packages/wonder-blocks-form/src/components/__tests__/checkbox.test.tsx, packages/wonder-blocks-form/src/components/__tests__/labeled-text-field.test.tsx, packages/wonder-blocks-form/src/components/__tests__/text-area.test.tsx, packages/wonder-blocks-form/src/components/__tests__/text-field.test.tsx, packages/wonder-blocks-search-field/src/components/__tests__/search-field.test.tsx, packages/wonder-blocks-tooltip/src/components/__tests__/tooltip.test.tsx, packages/wonder-blocks-testing/src/harness/adapters/__tests__/render-state.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (e25e77c) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2391"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2391

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Size Change: 0 B

Total Size: 97 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.77 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.77 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 887 B
packages/wonder-blocks-button/dist/es/index.js 4.04 kB
packages/wonder-blocks-cell/dist/es/index.js 2.01 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.06 kB
packages/wonder-blocks-core/dist/es/index.js 3.52 kB
packages/wonder-blocks-data/dist/es/index.js 6.24 kB
packages/wonder-blocks-dropdown/dist/es/index.js 19.1 kB
packages/wonder-blocks-form/dist/es/index.js 6.2 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-icon-button/dist/es/index.js 2.95 kB
packages/wonder-blocks-icon/dist/es/index.js 871 B
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.82 kB
packages/wonder-blocks-link/dist/es/index.js 2.28 kB
packages/wonder-blocks-modal/dist/es/index.js 5.42 kB
packages/wonder-blocks-pill/dist/es/index.js 1.65 kB
packages/wonder-blocks-popover/dist/es/index.js 4.85 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.52 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.36 kB
packages/wonder-blocks-switch/dist/es/index.js 1.92 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.74 kB
packages/wonder-blocks-testing/dist/es/index.js 1.07 kB
packages/wonder-blocks-theming/dist/es/index.js 693 B
packages/wonder-blocks-timing/dist/es/index.js 1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js 2.36 kB
packages/wonder-blocks-toolbar/dist/es/index.js 905 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.99 kB
packages/wonder-blocks-typography/dist/es/index.js 1.23 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Dec 11, 2024

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-sgbfhzshor.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 377
Tests with visual changes 0
Total stories 515
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 377

Copy link
Member

@jandrade jandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! thanks for the quick refactor :shipit:

Base automatically changed from wb1812.2.idcomponent to main December 16, 2024 15:24
@somewhatabstract somewhatabstract merged commit 56d961f into main Dec 16, 2024
11 checks passed
@somewhatabstract somewhatabstract deleted the wb1812.3.migratewb branch December 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants