[wb1812.1.deprecate] Mark ID stuff as deprecated #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d448bd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (4d1418d) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2388"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2388 |
|
Size Change: 0 B Total Size: 97.3 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ypvzrdjrrl.chromatic.com/ Chromatic results:
|
jandrade
approved these changes
Dec 11, 2024
|
The parent pull-request (#2387) has been merged into |
somewhatabstract
force-pushed
the
wb1812.1.deprecate
branch
from
8560759 to
d0bad9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
============================
============================
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first step in removing our custom ID utilities in favour of using the
useIdhook from React's API. This PR is not going to be merged/released on its own. Another PR will be coming to add anIdcomponent that wrapsuseIdso that there's an easier path for consumers to migrate.The difficult bit is moving from the provider architecture that gives an ID factory, to the
useId/Idapproach. However, long term, it should simplify things greatly.Upgrade note:
Upgrading to this will cause deprecation notices in consuming code. If a lint rule is set up to block deprecated usage (which it probably is), then those errors will have to be suppressed. A find/replace may help in some circumstances, but this may also be a manual process. The alternative, of course, is to actually modify stuff to the new approach.
Issue: WB-1812
Test plan:
yarn testyarn lint