[MulitSelect, SingleSelect] Move showOpenerLabelAsText out of sharedProps
#2379
Conversation
🦋 Changeset detectedLatest commit: 0371268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 101 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ihodcnumgc.chromatic.com/ Chromatic results:
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (b214511) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2379"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2379 |
|
Not ready for review yet, so I removed WB team. This is open so I can get the npm snapshot. Still need to test against webapp. |
|
Good catch @daniellewhyte ! I'm also working on some SingleSelect and MultiSelect changes! One of the PRs involves changing these to functional components and it will address this issue ( I'm going through some final testing/reviews for other changes but it'll include this fix when that's wrapped up (in case you wanted to leave things as is until then!) |
|
@beaesguerra Do you have an ETA on when that's expected to hit webapp? Perseus syncs its dependencies from webapp, so I was trying to deploy the updated the dropdown package sometime this week. |
|
@daniellewhyte Sounds good! We can get this PR through sooner then 😄 (some of the upcoming work is still being reviewed!) |
.changeset/famous-buckets-vanish.md
Outdated
| "@khanacademy/wonder-blocks-dropdown": patch | ||
| --- | ||
|
|
||
| [MultiSelect] Remove `showOpenerLabelAsText` from sharedProps that are passed to SelectOpener |
There was a problem hiding this comment.
minor: it will also be updated in SingleSelect!
| [MultiSelect] Remove `showOpenerLabelAsText` from sharedProps that are passed to SelectOpener | |
| [MultiSelect and SingleSelect] Remove `showOpenerLabelAsText` from sharedProps that are passed to SelectOpener |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
============================
============================
Continue to review full report in Codecov by Sentry.
|
daniellewhyte
changed the title
showOpenerLabelAsText out of sharedPropsshowOpenerLabelAsText out of sharedProps
## Summary: Follow up from #2354 the new `showOpenerLabel` was included in the `sharedProps` in the MultiSelect that are passed to the SelectOpener which caused many unit tests to fail when trying to update the dropdown package in webapp (Khan/webapp#27791) Issue: XXX-XXXX ## Test plan: Install the snapshot in webapp, yarn test Author: daniellewhyte Reviewers: beaesguerra Required Reviewers: Approved By: beaesguerra Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ⏭️ dependabot Pull Request URL: #2379
Summary:
Follow up from #2354 the new
showOpenerLabelAsTextwas included in thesharedPropsin the MultiSelect and SingleSelect that are passed to the SelectOpener which caused many unit tests to fail when trying to update the dropdown package in webapp (https://github.com/Khan/webapp/pull/27791)Issue: XXX-XXXX
Test plan:
Install the snapshot in webapp, yarn test