-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[encoderpatch] Patch TextEncoder/TextDecoder for tests #2307
Conversation
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (a4b684d) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2307" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2307 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-kavjxeiynq.chromatic.com/ Chromatic results:
|
Size Change: 0 B Total Size: 98.5 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks Jeff!
Summary:
React 18 requires these things but JSDOM doesn't include them, so we shim them
Issue: XXX-XXXX
Test plan:
yarn test
before React 18 update and after.