[initialfallback] Rename WithSSRPlaceholder to InitialFallback #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3cb03f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (16cd966) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2304"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2304 |
|
Size Change: -16 B (-0.02%) Total Size: 96.1 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 94.41% 95.14% +0.73%
==========================================
Files 254 254
Lines 30537 30533 -4
Branches 1715 1865 +150
==========================================
+ Hits 28830 29052 +222
+ Misses 1702 1462 -240
- Partials 5 19 +14
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ipllnlneff.chromatic.com/ Chromatic results:
|
jeresig
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This renames
WithSSRPlaceholderto more accurately reflect its purpose. This includes changing theplaceholderprop tofallbackso that we more closely match theReact.SuspenseAPI.To update code using
WithSSRPlaceholder:WithSSRPlaceholder placeholder=in files using that component toInitialFallback fallback=WithSSRPlaceholdertoInitialFallbackIssue: XXX-XXXX
Test plan:
yarn testyarn typecheckyarn start:storybookand view the docs for theInitialFallbackcomponent