Fix icon color on secondary and tertiary buttons (hover)

[jandrade]

Summary:

While working on some other changes, I noticed that the icon color on secondary
and tertiary buttons was not being set correctly. This PR fixes that issue by
setting the icon color to the same color as the text.

Issue: XXX-XXXX

Test plan:

Navigate to /?path=/story/packages-button--icon
Hover over the secondary and tertiary buttons
Verify that the icon color on secondary and tertiary buttons is the same as the
text color

BEFORE

Screen.Recording.2024-08-22.at.1.05.24.PM.mov

AFTER

Screen.Recording.2024-08-22.at.1.10.19.PM.mov

[changeset-bot]

🦋 Changeset detected

Latest commit: 24109b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@khanacademy/wonder-blocks-button	Patch
@khanacademy/wonder-blocks-banner	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[khan-actions-bot]

Gerald

Required Reviewers

• @Khan/wonder-blocks for changes to .changeset/small-walls-destroy.md, __docs__/wonder-blocks-button/button.stories.tsx, packages/wonder-blocks-button/src/themes/default.ts

---

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

[github-actions]

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (5f611b2) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2297"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2297

[github-actions]

Size Change: +4 B (0%)

Total Size: 96 kB

Filename	Size	Change
packages/wonder-blocks-button/dist/es/index.js	4.04 kB	+4 B (+0.1%)

ℹ️ View Unchanged

Filename	Size
packages/wonder-blocks-accordion/dist/es/index.js	3.78 kB
packages/wonder-blocks-banner/dist/es/index.js	1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js	1.61 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js	887 B
packages/wonder-blocks-cell/dist/es/index.js	2.01 kB
packages/wonder-blocks-clickable/dist/es/index.js	3.06 kB
packages/wonder-blocks-core/dist/es/index.js	3.45 kB
packages/wonder-blocks-data/dist/es/index.js	6.24 kB
packages/wonder-blocks-dropdown/dist/es/index.js	14.1 kB
packages/wonder-blocks-form/dist/es/index.js	6.11 kB
packages/wonder-blocks-grid/dist/es/index.js	1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js	4.76 kB
packages/wonder-blocks-icon-button/dist/es/index.js	2.99 kB
packages/wonder-blocks-icon/dist/es/index.js	828 B
packages/wonder-blocks-labeled-field/dist/es/index.js	72 B
packages/wonder-blocks-layout/dist/es/index.js	1.82 kB
packages/wonder-blocks-link/dist/es/index.js	2.28 kB
packages/wonder-blocks-modal/dist/es/index.js	5.36 kB
packages/wonder-blocks-pill/dist/es/index.js	1.64 kB
packages/wonder-blocks-popover/dist/es/index.js	4.85 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js	1.52 kB
packages/wonder-blocks-search-field/dist/es/index.js	1.3 kB
packages/wonder-blocks-switch/dist/es/index.js	1.94 kB
packages/wonder-blocks-testing-core/dist/es/index.js	3.64 kB
packages/wonder-blocks-testing/dist/es/index.js	1.13 kB
packages/wonder-blocks-theming/dist/es/index.js	693 B
packages/wonder-blocks-timing/dist/es/index.js	1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js	2.1 kB
packages/wonder-blocks-toolbar/dist/es/index.js	855 B
packages/wonder-blocks-tooltip/dist/es/index.js	7 kB
packages/wonder-blocks-typography/dist/es/index.js	1.23 kB

_{compressed-size-action}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (79b9fdb) to head (24109b6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   94.50%   95.84%   +1.33%     
==========================================
  Files         254      254              
  Lines       30477    30479       +2     
  Branches     1719     2460     +741     
==========================================
+ Hits        28803    29212     +409     
+ Misses       1669     1256     -413     
- Partials        5       11       +6     

Files	Coverage Δ
...ackages/wonder-blocks-button/src/themes/default.ts	100.00% <100.00%> (ø)

... and 44 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b9fdb...24109b6. Read the comment docs.

[github-actions]

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-ydmgxcemue.chromatic.com/

Chromatic results:

Metric	Total
Captured snapshots	359
Tests with visual changes	2
Total stories	477
Inherited (not captured) snapshots [TurboSnap]	0
Tests on the build	359

[beaesguerra]

Nice fix! 😄