[fixexternals] Fix how react-dom/server is imported #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sure react-dom/server is properly imported
🦋 Changeset detectedLatest commit: fd8c85e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (0ee637b) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2272"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2272 |
|
Size Change: -4.21 kB (-4.28%) Total Size: 94 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-jvwbfjqrsi.chromatic.com/ Chromatic results:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2272 +/- ##
==========================================
+ Coverage 94.21% 95.57% +1.35%
==========================================
Files 251 251
Lines 29666 29666
Branches 1685 2458 +773
==========================================
+ Hits 27951 28352 +401
+ Misses 1710 1309 -401
Partials 5 5 see 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jandrade
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Turns out that the rollup plugin, autoexternals, doesn't handle sub-package improts, like
react-dom/server. However, reading the issue report on that package, I saw a link to another, more up-to-date package, that does handle this. So I switched to that package, and now everything works as expected.I did have to explicitly use the
mjsextension for the rollup config, but that's a small price to pay for the benefits of the new package.Issue: XXX-XXXX
Test plan:
yarn buildto see that the build works.I'll also verify the packages in webapp to check everything else is fine, though the storybook should also check out.