Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all special characters in IDs, except whitespace. #2231

Merged
merged 1 commit into from
May 21, 2024

Allow all special characters in IDs, except whitespace.

e384dff
Select commit
Loading
Failed to load commit list.
Merged

Allow all special characters in IDs, except whitespace. #2231

Allow all special characters in IDs, except whitespace.
e384dff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2024 in 0s

95.09% (+0.66%) compared to f01e83d

View this Pull Request on Codecov

95.09% (+0.66%) compared to f01e83d

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (f01e83d) to head (e384dff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
+ Coverage   94.43%   95.09%   +0.66%     
==========================================
  Files         248      248              
  Lines       29238    29237       -1     
  Branches     1643     2329     +686     
==========================================
+ Hits        27611    27804     +193     
+ Misses       1623     1429     -194     
  Partials        4        4              
Files Coverage Δ
...s/wonder-blocks-core/src/util/unique-id-factory.ts 93.44% <100.00%> (+3.12%) ⬆️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01e83d...e384dff. Read the comment docs.