Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow consumers to set tabindex on pill when clickable #2229

Merged
merged 2 commits into from
May 16, 2024

Conversation

nedredmond
Copy link
Contributor

Exposes tabIndex and passes to Clickable wrapper. Adds test.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 7b5d512

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/wonder-blocks-pill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nedredmond nedredmond requested a review from jandrade May 16, 2024 19:45
@khan-actions-bot khan-actions-bot requested a review from a team May 16, 2024 19:45
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented May 16, 2024

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/pink-tables-attack.md, packages/wonder-blocks-pill/src/components/pill.tsx, packages/wonder-blocks-pill/src/components/__tests__/pill.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented May 16, 2024

Size Change: +15 B (+0.02%)

Total Size: 96.5 kB

Filename Size Change
packages/wonder-blocks-pill/dist/es/index.js 1.65 kB +15 B (+0.92%)
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.78 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.28 kB
packages/wonder-blocks-cell/dist/es/index.js 2.24 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.29 kB
packages/wonder-blocks-core/dist/es/index.js 3.7 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 13.9 kB
packages/wonder-blocks-form/dist/es/index.js 5.31 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.56 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.89 kB
packages/wonder-blocks-link/dist/es/index.js 2.53 kB
packages/wonder-blocks-modal/dist/es/index.js 5.52 kB
packages/wonder-blocks-popover/dist/es/index.js 4.86 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-switch/dist/es/index.js 2.1 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 697 B
packages/wonder-blocks-timing/dist/es/index.js 1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js 1.74 kB
packages/wonder-blocks-toolbar/dist/es/index.js 857 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.91 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (66860c3) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2229"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2229

Copy link
Contributor

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-hatotoapmo.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 49
Tests with visual changes 0
Total stories 413
Inherited (not captured) snapshots [TurboSnap] 278
Tests on the build 327

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (e8d25c9) to head (7b5d512).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
+ Coverage   94.32%   94.98%   +0.65%     
==========================================
  Files         248      248              
  Lines       29232    29238       +6     
  Branches     2398     2354      -44     
==========================================
+ Hits        27574    27771     +197     
+ Misses       1615     1456     -159     
+ Partials       43       11      -32     
Files Coverage Δ
...ackages/wonder-blocks-pill/src/components/pill.tsx 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d25c9...7b5d512. Read the comment docs.

@nedredmond nedredmond merged commit bf1e3d8 into main May 16, 2024
16 checks passed
@nedredmond nedredmond deleted the ned/class-10254 branch May 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants