-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow consumers to set tabindex on pill when clickable #2229
Conversation
🦋 Changeset detectedLatest commit: 7b5d512 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +15 B (+0.02%) Total Size: 96.5 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (66860c3) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2229" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2229 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-hatotoapmo.chromatic.com/ Chromatic results:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
+ Coverage 94.32% 94.98% +0.65%
==========================================
Files 248 248
Lines 29232 29238 +6
Branches 2398 2354 -44
==========================================
+ Hits 27574 27771 +197
+ Misses 1615 1456 -159
+ Partials 43 11 -32
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Exposes tabIndex and passes to Clickable wrapper. Adds test.