Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #2220

Merged
merged 1 commit into from
May 9, 2024
Merged

Version Packages #2220

merged 1 commit into from
May 9, 2024

Conversation

khan-actions-bot
Copy link
Contributor

@khan-actions-bot khan-actions-bot commented May 1, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@khanacademy/[email protected]

Major Changes

  • f72f7dd: - [BREAKING CHANGE] Policy types are now using enums across all APIs
    • [BREAKING CHANGE] useScheduledTimeout has been renamed to useTimeout and the original useTimeout has been removed. To update existing uses of useTimeout to the new API: if active was true just delete that argument or replace it with {schedulingPolicy: SchedulingPolicy.Immediately}; if active was false replace it with {schedulingPolicy: SchedulingPolicy.OnDemand}.
    • [BREAKING CHANGE] useScheduledInterval has been renamed to useInterval and the original useInterval has been removed. To update existing uses of useInterval to the new API: if active was true just delete that argument or replace it with {schedulingPolicy: SchedulingPolicy.Immediately}; if active was false replace it with {schedulingPolicy: SchedulingPolicy.OnDemand}.
    • [NEW] useTimeout now supports an optional ActionPolicy in the options. The default is to not reset the timeout when the action callback changes. This can be changed to ActionPolicy.Reset to reset the timeout when the action callback changes (it is recommended that you use useCallback on your action callback to avoid resetting the timeout everytime a component renders when using the Reset policy).
    • [NEW] useInterval now supports an optional ActionPolicy in the options. The default is to not reset the interval when the action callback changes. This can be changed to ActionPolicy.Reset to reset the interval when the action callback changes (it is recommended that you use useCallback on your action callback to avoid resetting the interval everytime a component renders when using the Reset policy).
    • [BUGFIX] useTimeout will now correctly reset the timeout when the set method is called, as intended.
    • [BUGFIX] useInterval will now correctly reset the interval when the set method is called, as intended.

@khanacademy/[email protected]

Minor Changes

  • 7030948: Add Listbox component with Single and Multiple selection support

Patch Changes

@khanacademy/[email protected]

Patch Changes

@khanacademy/[email protected]

Patch Changes

@khanacademy/[email protected]

Patch Changes

@khanacademy/[email protected]

Patch Changes

@khan-actions-bot
Copy link
Contributor Author

khan-actions-bot commented May 1, 2024

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to packages/wonder-blocks-birthday-picker/CHANGELOG.md, packages/wonder-blocks-birthday-picker/package.json, packages/wonder-blocks-dropdown/CHANGELOG.md, packages/wonder-blocks-dropdown/package.json, packages/wonder-blocks-modal/CHANGELOG.md, packages/wonder-blocks-modal/package.json, packages/wonder-blocks-popover/CHANGELOG.md, packages/wonder-blocks-popover/package.json, packages/wonder-blocks-timing/CHANGELOG.md, packages/wonder-blocks-timing/package.json, packages/wonder-blocks-tooltip/CHANGELOG.md, packages/wonder-blocks-tooltip/package.json

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team May 1, 2024 22:04
Copy link
Contributor

github-actions bot commented May 1, 2024

Size Change: 0 B

Total Size: 96.1 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.78 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.28 kB
packages/wonder-blocks-cell/dist/es/index.js 2.24 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.29 kB
packages/wonder-blocks-core/dist/es/index.js 3.7 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 13.9 kB
packages/wonder-blocks-form/dist/es/index.js 5.31 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.56 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.89 kB
packages/wonder-blocks-link/dist/es/index.js 2.53 kB
packages/wonder-blocks-modal/dist/es/index.js 5.52 kB
packages/wonder-blocks-pill/dist/es/index.js 1.27 kB
packages/wonder-blocks-popover/dist/es/index.js 4.86 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-switch/dist/es/index.js 2.1 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 697 B
packages/wonder-blocks-timing/dist/es/index.js 1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js 1.74 kB
packages/wonder-blocks-toolbar/dist/es/index.js 857 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.91 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (f72f7dd) to head (d08485d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
+ Coverage   94.47%   95.66%   +1.18%     
==========================================
  Files         248      248              
  Lines       29229    29229              
  Branches     1638     2447     +809     
==========================================
+ Hits        27614    27961     +347     
+ Misses       1611     1252     -359     
- Partials        4       16      +12     

see 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72f7dd...d08485d. Read the comment docs.

@khan-actions-bot khan-actions-bot force-pushed the changeset-release/main branch from 0fdba99 to d08485d Compare May 8, 2024 21:30
Copy link
Member

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somewhatabstract somewhatabstract merged commit 52607c2 into main May 9, 2024
26 of 28 checks passed
@somewhatabstract somewhatabstract deleted the changeset-release/main branch May 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants