WB-1672: Form fields: Update border color to offBlack50 #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36f9ede The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jandrade
commented
Mar 15, 2024
| color: color.offBlack, | ||
| "::placeholder": { | ||
| color: color.offBlack64, | ||
| }, | ||
| }, | ||
| error: { | ||
| background: `${mix(color.fadedRed8, color.white)}`, |
There was a problem hiding this comment.
note: This color is now part of the official WB color palette.
|
Size Change: -3 B (0%) Total Size: 96.8 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (294951a) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2199"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2199 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
+ Coverage 94.02% 95.28% +1.26%
==========================================
Files 248 248
Lines 29387 29387
Branches 2402 1836 -566
==========================================
+ Hits 27630 28001 +371
+ Misses 1753 1380 -373
- Partials 4 6 +2
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-oafslyxeqe.chromatic.com/ Chromatic results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For a11y reasons, we are changing the border color from
offBlack16tooffBlack50. This will solve a color contrast issue for non-text elements liketextfields and dropdown openers.
This PR updates this color in
TextField,MultiSelectandSingleSelecttomatch these changes.
TextField / LabeledTextField:
MultiSelect / SingleSelect:
Issue: WB-1672
Test plan:
Verify the border color of the
Textfield,MultiSelectandSingleSelectinStorybook and chromatic, and ensure that the color looks as we expect.