Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENT] WB-1588: Dropdowns + Cell prototype #2097

Closed
wants to merge 3 commits into from
Closed

Conversation

jandrade
Copy link
Member

Summary:

Prototyping using Cells as dropdown options.

The work here will help us to drive the design of the dropdowns + cells.

Issue: WB-1588

Test plan:

Verify that the SingleSelect stories still work and that the focus and hover
States are different one from the other.

@jandrade jandrade self-assigned this Oct 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: 3db3cf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Size Change: +910 B (+1%)

Total Size: 93.5 kB

Filename Size Change
packages/wonder-blocks-cell/dist/es/index.js 2.22 kB +29 B (+1%)
packages/wonder-blocks-clickable/dist/es/index.js 3.24 kB +8 B (0%)
packages/wonder-blocks-dropdown/dist/es/index.js 12.9 kB +873 B (+7%) 🔍
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.53 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.26 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-form/dist/es/index.js 5.34 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.06 kB
packages/wonder-blocks-icon/dist/es/index.js 3.04 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.88 kB
packages/wonder-blocks-link/dist/es/index.js 2.54 kB
packages/wonder-blocks-modal/dist/es/index.js 5.04 kB
packages/wonder-blocks-pill/dist/es/index.js 1.03 kB
packages/wonder-blocks-popover/dist/es/index.js 4.33 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.06 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 1.21 kB
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-toolbar/dist/es/index.js 862 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-qngkdthaph.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 321
Tests with visual changes 8
Total stories 393
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 321

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2097 (3db3cf6) into main (db2b87c) will decrease coverage by 9.72%.
The diff coverage is 99.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
- Coverage   97.09%   87.38%   -9.72%     
==========================================
  Files         243      243              
  Lines       28205    28175      -30     
  Branches     2463     1847     -616     
==========================================
- Hits        27386    24621    -2765     
- Misses        819     3554    +2735     
Files Coverage Δ
...-blocks-cell/src/components/internal/cell-core.tsx 100.00% <100.00%> (ø)
...nder-blocks-clickable/src/components/clickable.tsx 91.60% <100.00%> (-8.40%) ⬇️
...der-blocks-dropdown/src/components/action-item.tsx 100.00% <100.00%> (ø)
...es/wonder-blocks-dropdown/src/components/check.tsx 100.00% <100.00%> (ø)
...r-blocks-dropdown/src/components/dropdown-core.tsx 83.24% <100.00%> (-16.22%) ⬇️
...der-blocks-dropdown/src/components/option-item.tsx 100.00% <100.00%> (ø)
...wonder-blocks-dropdown/src/components/checkbox.tsx 83.03% <88.88%> (-16.97%) ⬇️

... and 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2b87c...3db3cf6. Read the comment docs.

@jandrade jandrade closed this Dec 13, 2023
@jandrade jandrade deleted the dropdown-cell branch December 13, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant