Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1615: Add PhosphorIcon support to Switch #2094

Merged
merged 1 commit into from
Oct 23, 2023
Merged

WB-1615: Add PhosphorIcon support to Switch #2094

merged 1 commit into from
Oct 23, 2023

Conversation

jandrade
Copy link
Member

Summary:

Replaces Icon with the new PhosphorIcon component in Switch. Now
Switch only should accept PhosphorIcon instances in its icon prop.

Issue: WB-1615

Test plan:

In Storybook, verify that the Switch icon stories look correct.

Also compare the changes in Chromatic.

@jandrade jandrade self-assigned this Oct 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 748a48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/wonder-blocks-switch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/blue-cows-clap.md, __docs__/wonder-blocks-switch/switch.argtypes.tsx, __docs__/wonder-blocks-switch/switch.stories.tsx, packages/wonder-blocks-switch/src/components/switch.tsx, packages/wonder-blocks-switch/src/components/__tests__/switch.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 20, 2023 21:08
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 91.4 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 2.86 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.69 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.09 kB
packages/wonder-blocks-cell/dist/es/index.js 2.19 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.21 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 12 kB
packages/wonder-blocks-form/dist/es/index.js 5.42 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 2.22 kB
packages/wonder-blocks-icon/dist/es/index.js 3.04 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.88 kB
packages/wonder-blocks-link/dist/es/index.js 3.03 kB
packages/wonder-blocks-modal/dist/es/index.js 5.04 kB
packages/wonder-blocks-pill/dist/es/index.js 1.03 kB
packages/wonder-blocks-popover/dist/es/index.js 4.33 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.53 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.06 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 1.21 kB
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-toolbar/dist/es/index.js 862 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

@github-actions
Copy link
Contributor

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-gcnwbyigsz.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 5
Tests with visual changes 4
Total stories 381
Inherited (not captured) snapshots [TurboSnap] 316
Tests on the build 321

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2094 (748a48c) into main (9489dde) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2094      +/-   ##
==========================================
- Coverage   97.04%   97.01%   -0.03%     
==========================================
  Files         240      240              
  Lines       27532    27534       +2     
  Branches     2415     2334      -81     
==========================================
- Hits        26719    26713       -6     
- Misses        813      821       +8     
Files Coverage Δ
...ges/wonder-blocks-switch/src/components/switch.tsx 99.63% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9489dde...748a48c. Read the comment docs.

@jandrade jandrade requested a review from nishasy October 23, 2023 15:22
Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@nishasy nishasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jandrade jandrade merged commit 45a3042 into main Oct 23, 2023
@jandrade jandrade deleted the phosphor-switch branch October 23, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants