-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB-1615: Add PhosphorIcon support to Switch #2094
Conversation
🦋 Changeset detectedLatest commit: 748a48c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 91.4 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-gcnwbyigsz.chromatic.com/ Chromatic results:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
- Coverage 97.04% 97.01% -0.03%
==========================================
Files 240 240
Lines 27532 27534 +2
Branches 2415 2334 -81
==========================================
- Hits 26719 26713 -6
- Misses 813 821 +8
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Summary:
Replaces Icon with the new PhosphorIcon component in
Switch
. NowSwitch only should accept
PhosphorIcon
instances in itsicon
prop.Issue: WB-1615
Test plan:
In Storybook, verify that the
Switch
icon stories look correct.Also compare the changes in Chromatic.