Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Upgrade Storybook to v7.5 #2092

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[🔥AUDIT🔥] Upgrade Storybook to v7.5 #2092

merged 1 commit into from
Oct 19, 2023

Conversation

jandrade
Copy link
Member

🖍 This is an audit! 🖍

Summary:

Upgraded Storybook to v7.5.

Issue: XXX-XXXX

Test plan:

Verify that Storybook still works.

@jandrade jandrade self-assigned this Oct 19, 2023
@jandrade jandrade added the audit PR is using the audit OLC flow label Oct 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

⚠️ No Changeset found

Latest commit: 9c2c473

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to package.json, yarn.lock

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 19, 2023 20:14
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 93 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 2.86 kB
packages/wonder-blocks-banner/dist/es/index.js 3.09 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.69 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.09 kB
packages/wonder-blocks-cell/dist/es/index.js 2.19 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.21 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 12 kB
packages/wonder-blocks-form/dist/es/index.js 5.42 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 2.22 kB
packages/wonder-blocks-icon/dist/es/index.js 3.04 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.88 kB
packages/wonder-blocks-link/dist/es/index.js 3.03 kB
packages/wonder-blocks-modal/dist/es/index.js 5.04 kB
packages/wonder-blocks-pill/dist/es/index.js 1.03 kB
packages/wonder-blocks-popover/dist/es/index.js 4.33 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.53 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.06 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 1.21 kB
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-toolbar/dist/es/index.js 862 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

@github-actions
Copy link
Contributor

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (9d8097f) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2092"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2092

@github-actions
Copy link
Contributor

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-ahdssbfitl.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 321
Tests with visual changes 1
Total stories 381
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 321

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2092 (9c2c473) into main (7055ca9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         241      241           
  Lines       27538    27538           
  Branches     2415     2335   -80     
=======================================
  Hits        26717    26717           
  Misses        821      821           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7055ca9...9c2c473. Read the comment docs.

@jandrade jandrade merged commit 0b4c41d into main Oct 19, 2023
13 checks passed
@jandrade jandrade deleted the sb-75 branch October 19, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit PR is using the audit OLC flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants