Skip to content

Commit

Permalink
[wb1812.4.delete] Delete the custom identifier generation API (#2398)
Browse files Browse the repository at this point in the history
## Summary:
This deletes the components and hooks that we had for generating hydration-safe identifiers. We are now using the built-in `useId` hook internally, and expect our consumers to do the same (or the `Id` component we provide for more complex cases).

This should not be released until the following PRs are merged and deployed to webapp:
 - Khan/webapp#28161
 - Khan/webapp#28156

Issue: WB-1812

## Test plan:
`yarn test`
`yarn typecheck`

Author: somewhatabstract

Reviewers: beaesguerra

Required Reviewers:

Approved By: beaesguerra

Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ⏹️  [cancelled] Chromatic - Get results on regular PRs, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ⏹️  [cancelled] Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ⌛ undefined

Pull Request URL: #2398
  • Loading branch information
somewhatabstract authored Dec 17, 2024
1 parent 3c1682f commit d23c9c5
Show file tree
Hide file tree
Showing 22 changed files with 35 additions and 1,601 deletions.
5 changes: 5 additions & 0 deletions .changeset/lemon-seals-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/wonder-blocks-core": major
---

Delete the custom identifier generation API
92 changes: 0 additions & 92 deletions __docs__/wonder-blocks-core/id-provider.stories.tsx

This file was deleted.

137 changes: 0 additions & 137 deletions __docs__/wonder-blocks-core/unique-id-provider.stories.tsx

This file was deleted.

50 changes: 0 additions & 50 deletions __docs__/wonder-blocks-core/use-unique-id.mdx

This file was deleted.

Loading

0 comments on commit d23c9c5

Please sign in to comment.