Skip to content

Commit

Permalink
[🔥AUDIT🔥] [ignoretsxtestfiles] Ignore tsx test files in changeset che…
Browse files Browse the repository at this point in the history
…ck (#2270)

🖍 _This is an audit!_ 🖍

## Summary:
This means we can edit tsx test files without being asked to add per package changesets.

Issue: XXX-XXXX

## Test plan:
Edit a tsx test file and push to a branch, raise a PR and see that changeset check does not ask for a changeset.

Author: somewhatabstract

Auditors: jeresig

Required Reviewers:

Approved By: jeresig

Checks: ⌛ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⌛ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ⌛ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️  dependabot, ⌛ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #2270
  • Loading branch information
somewhatabstract authored Jul 12, 2024
1 parent eab37b8 commit 9f08a55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/node-ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
with:
changed-files: ${{ steps.changed.outputs.files }}
files: packages/ # Only look for changes in packages
globs: "!(**/__tests__/**), !(**/dist/*), !(**/*.test.ts)" # Ignore test files
globs: "!(**/__tests__/**), !(**/dist/*), !(**/*.test.{ts,tsx})" # Ignore test files
matchAllGlobs: true # All globs must match (disjunction is the default)
conjunctive: true # Only return files that match all of the above

Expand Down

0 comments on commit 9f08a55

Please sign in to comment.